Skip to content

Sync strings #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Sync strings #1366

merged 3 commits into from
Sep 18, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 18, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : i18n

Content

Integrate latest version of French and German strings, after internal fixes.

Motivation and context

Improve wording in French and German.

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner September 18, 2023 14:44
@bmarty bmarty requested review from julioromano and ganfra and removed request for a team and julioromano September 18, 2023 14:44
@bmarty
Copy link
Member Author

bmarty commented Sep 18, 2023

Assigning to French speaker :)

@ElementBot
Copy link
Collaborator

ElementBot commented Sep 18, 2023

Warnings
⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L173 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L178 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

Generated by 🚫 dangerJS against f7ae97f

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ZjXPzS

@bmarty
Copy link
Member Author

bmarty commented Sep 18, 2023

(recording screenshot triggered)

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I guess

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1d65cc9) 57.75% compared to head (f7ae97f) 57.75%.
Report is 8 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1366   +/-   ##
========================================
  Coverage    57.75%   57.75%           
========================================
  Files         1120     1120           
  Lines        29719    29719           
  Branches      6102     6102           
========================================
  Hits         17163    17163           
  Misses        9873     9873           
  Partials      2683     2683           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 635a4eb into develop Sep 18, 2023
@bmarty bmarty deleted the feature/bma/syncStrings branch September 18, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants