Skip to content

Fix long click on simple formatted messages #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

jmartinesp
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Forward the right onClick and onLongClick actions to the default ClickableLinkText inside HtmlDocument, used for simple formatted messages (formatted as in having a formatted_body, that is, HTML content).

Motivation and context

Should fix #1232.

Tests

  • Try long pressing different messages: simple text messages, messages written with the rich text editor (HTML content), messages with links...

Previously some of those were working if you long pressed on some places without text, not they should work while long pressing in the middle of some texts.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 11

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner September 14, 2023 09:06
@jmartinesp jmartinesp requested review from bmarty and removed request for a team September 14, 2023 09:06
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Ls8KXm

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jmartinesp jmartinesp merged commit 7546713 into develop Sep 14, 2023
@jmartinesp jmartinesp deleted the fix/jme/1232-long-press-on-simple-text-messages branch September 14, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to react/forward/reply on a reply message
2 participants