Skip to content

Optimize WarmUpRule #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2023
Merged

Optimize WarmUpRule #1310

merged 2 commits into from
Sep 13, 2023

Conversation

julioromano
Copy link

This PR is made of 2 commits.
The first is just a mass rename in order to spare 1 line of code every time WarmUpRule is used.
The second tweaks WarmUpRule so that the warmup code is only run once per test class.

@julioromano julioromano requested a review from a team as a code owner September 13, 2023 13:47
@julioromano julioromano requested review from bmarty and removed request for a team September 13, 2023 13:47
@julioromano julioromano self-assigned this Sep 13, 2023
@julioromano julioromano mentioned this pull request Sep 13, 2023
Merged
14 tasks
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/umRkC5

bmarty
bmarty approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@julioromano julioromano merged commit bdc6cdd into develop Sep 13, 2023
@julioromano julioromano deleted the julioromano/remove_jvm_field branch September 13, 2023 14:27
jonnyandrew
jonnyandrew reviewed Sep 13, 2023
View reviewed changes
Copy link
Contributor

@jonnyandrew jonnyandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnyandrew jonnyandrew jonnyandrew left review comments

@bmarty bmarty bmarty approved these changes

Assignees

@julioromano julioromano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julioromano @bmarty @jonnyandrew