Skip to content

Poll Creation: Switch focus to newly added option field when clicking "Add option". #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

julioromano
Copy link

Poll Creation: Switch focus to newly added option field when clicking "Add option".

@julioromano julioromano requested a review from a team as a code owner September 13, 2023 09:04
@julioromano julioromano self-assigned this Sep 13, 2023
@julioromano julioromano requested review from jmartinesp and removed request for a team September 13, 2023 09:04
@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/z2xTBm

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 74.28% and project coverage change: +0.01% 🎉

Comparison is base (b426084) 57.70% compared to head (21e25e9) 57.72%.
Report is 3 commits behind head on develop.

❗ Current head 21e25e9 differs from pull request most recent head f456eea. Consider uploading reports for the commit f456eea to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1294      +/-   ##
===========================================
+ Coverage    57.70%   57.72%   +0.01%     
===========================================
  Files         1087     1087              
  Lines        28649    28664      +15     
  Branches      5866     5872       +6     
===========================================
+ Hits         16531    16545      +14     
  Misses        9544     9544              
- Partials      2574     2575       +1     
Files Changed Coverage Δ
...ndroid/features/poll/impl/create/CreatePollView.kt 60.74% <74.28%> (+5.31%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually makes the latest option also the one with focus when you start creating a poll. Maybe the answerFocusRequester should be added only to the latest item and called after tapping on add option?

Marco Romano added 2 commits September 13, 2023 13:43
… "Add option".

- Also scrolls the list to make the "Add option" button visible for further additions.
@julioromano julioromano force-pushed the julioromano/polls_create_focus_fix branch from f644a57 to 21e25e9 Compare September 13, 2023 12:13
@julioromano
Copy link
Author

Should have fixed it, I also added a programmatic scroll so that the "Add option" button is still visible after adding an option

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to fix it. After both our changes I think it's working perfectly now. LGTM!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@julioromano julioromano merged commit 49c723e into develop Sep 13, 2023
@julioromano julioromano deleted the julioromano/polls_create_focus_fix branch September 13, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants