-
Notifications
You must be signed in to change notification settings - Fork 232
Poll Creation: Switch focus to newly added option field when clicking "Add option". #1294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1294 +/- ##
===========================================
+ Coverage 57.70% 57.72% +0.01%
===========================================
Files 1087 1087
Lines 28649 28664 +15
Branches 5866 5872 +6
===========================================
+ Hits 16531 16545 +14
Misses 9544 9544
- Partials 2574 2575 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually makes the latest option also the one with focus when you start creating a poll. Maybe the answerFocusRequester
should be added only to the latest item and called after tapping on add option?
… "Add option". - Also scrolls the list to make the "Add option" button visible for further additions.
f644a57
to
21e25e9
Compare
Should have fixed it, I also added a programmatic scroll so that the "Add option" button is still visible after adding an option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to fix it. After both our changes I think it's working perfectly now. LGTM!
Kudos, SonarCloud Quality Gate passed! |
Poll Creation: Switch focus to newly added option field when clicking "Add option".