Skip to content

Send composer analytics when sending a message #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

julioromano
Copy link

@julioromano julioromano commented Sep 12, 2023

Composer event are not sent to posthog when sending messages.

After investigation I've found that in MessageComposerPresenter the analyticsService.capture() call is invoked in the SetMode event handler rather than in the SendMessage event handler.

This change should result in the desired behavior.

@julioromano julioromano marked this pull request as ready for review September 12, 2023 14:59
@julioromano julioromano requested a review from a team as a code owner September 12, 2023 14:59
@julioromano julioromano requested review from bmarty and jmartinesp and removed request for a team September 12, 2023 14:59
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/BqEhhJ

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have checked on EA and we do the same thing.

Naming the analytics event Composer is a bit weird though, something like SendMessage should be more appropriate / more obvious, but this is out of scope of this PR.

@julioromano julioromano merged commit f327726 into develop Sep 13, 2023
@julioromano julioromano deleted the julioromano/composer-analytics branch September 13, 2023 05:59
julioromano pushed a commit that referenced this pull request Sep 13, 2023
julioromano pushed a commit that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants