Skip to content

[Compound] Improve Bloom #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 12, 2023
Merged

[Compound] Improve Bloom #1272

merged 6 commits into from
Sep 12, 2023

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Sep 11, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Simplify bloom effect.
  • Display very subtle effect in light mode for avatars with soft colors.

Motivation and context

Iteration on Bloom.

Screenshots / GIFs

In the PR.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 11

Checklist

jmartinesp and others added 2 commits September 11, 2023 17:42
- Simplify bloom blurred image.
- Display very subtle bloom for avatars with soft colors.
@jmartinesp jmartinesp requested a review from a team as a code owner September 11, 2023 15:44
@jmartinesp jmartinesp requested review from bmarty and removed request for a team September 11, 2023 15:44
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why these images are affected. I mean, they do use blurhash, but their implementation isn't related at all to Bloom's.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's strange... Maybe due to #1262 ?
But CI was happy...

Copy link
Member

@bmarty bmarty Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(other recent screenshot recordings are not updating those files, so this is not #1262)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/EmVaCv

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 84.61% and no project coverage change.

Comparison is base (3d0c5e7) 57.62% compared to head (e845a07) 57.62%.
Report is 3 commits behind head on develop.

❗ Current head e845a07 differs from pull request most recent head 488444f. Consider uploading reports for the commit 488444f to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1272   +/-   ##
========================================
  Coverage    57.62%   57.62%           
========================================
  Files         1087     1087           
  Lines        28556    28566   +10     
  Branches      5852     5854    +2     
========================================
+ Hits         16454    16462    +8     
- Misses        9533     9535    +2     
  Partials      2569     2569           
Files Changed Coverage Δ
...android/libraries/designsystem/components/Bloom.kt 74.89% <77.77%> (-0.11%) ⬇️
...eatures/roomlist/impl/components/RoomListTopBar.kt 63.96% <100.00%> (+1.00%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for iterating on this!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's strange... Maybe due to #1262 ?
But CI was happy...

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jmartinesp jmartinesp merged commit fb9d08b into develop Sep 12, 2023
@jmartinesp jmartinesp deleted the fix/jme/improve-bloom branch September 12, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants