-
Notifications
You must be signed in to change notification settings - Fork 232
[Compound] Improve Bloom #1272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Compound] Improve Bloom #1272
Conversation
- Simplify bloom blurred image. - Display very subtle bloom for avatars with soft colors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea why these images are affected. I mean, they do use blurhash, but their implementation isn't related at all to Bloom's.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's strange... Maybe due to #1262 ?
But CI was happy...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(other recent screenshot recordings are not updating those files, so this is not #1262)
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1272 +/- ##
========================================
Coverage 57.62% 57.62%
========================================
Files 1087 1087
Lines 28556 28566 +10
Branches 5852 5854 +2
========================================
+ Hits 16454 16462 +8
- Misses 9533 9535 +2
Partials 2569 2569
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for iterating on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's strange... Maybe due to #1262 ?
But CI was happy...
Kudos, SonarCloud Quality Gate passed! |
Type of change
Content
Motivation and context
Iteration on Bloom.
Screenshots / GIFs
In the PR.
Tested devices
Checklist