Reply action: harmonize condition #1271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
commented
Sep 11, 2023
| add(TimelineItemAction.Reply) | ||
| if (userCanSendMessage) { | ||
| add(TimelineItemAction.Reply) | ||
| } |
bmarty
commented
Sep 11, 2023
| @@ -189,7 +190,7 @@ fun TimelineItemRow( | |||
| TimelineItemEventRow( | |||
| event = timelineItem, | |||
| isHighlighted = highlightedItem == timelineItem.identifier(), | |||
| canReply = canReply, | |||
| canReply = userHasPermissionToSendMessage && timelineItem.content.canBeReplied(), | |||
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1271 +/- ##
===========================================
+ Coverage 57.42% 57.66% +0.24%
===========================================
Files 1086 1087 +1
Lines 28270 28570 +300
Branches 5806 5857 +51
===========================================
+ Hits 16234 16475 +241
- Misses 9495 9525 +30
- Partials 2541 2570 +29
☔ View full report in Codecov by Sentry. |
jmartinesp
approved these changes
Sep 12, 2023
| @@ -101,7 +103,8 @@ class ActionListPresenter @Inject constructor( | |||
| buildList { | |||
| val isMineOrCanRedact = timelineItem.isMine || userCanRedact | |||
|
|
|||
| // TODO Poll: Reply to poll | |||
| // TODO Poll: Reply to poll. Ensure to update `fun TimelineItemEventContent.canBeReplied()` | |||
| * Determine if the event content can be replied to. | ||
| * Note: it should match the logic in [io.element.android.features.messages.impl.actionlist.ActionListPresenter]. | ||
| */ | ||
| fun TimelineItemEventContent.canBeReplied(): Boolean = |
There was a problem hiding this comment.
Nit: it should probably be canBeRepliedTo.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Harmonize condition to enable or disable reply action.
Motivation and context
Closes #1173
Screenshots / GIFs
Tests
Tested devices
Checklist