De-duplicate sonar job in the CI #1238
Conversation
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
| @@ -14,7 +14,7 @@ env: | |||
|
|
|||
| jobs: | |||
| sonar: | |||
| name: Project Check Suite | |||
| name: Sonar Quality Checks | |||
There was a problem hiding this comment.
I am pretty sure I had done this change in the past, but I cannot find where. The name could be updated too (at line 1)
| run: | | ||
| npm install --save-dev @babel/core | ||
| npm install --save-dev @babel/plugin-transform-flow-strip-types | ||
| yarn add danger-plugin-lint-report --dev |
There was a problem hiding this comment.
I remember having removed this as well :/
There was a problem hiding this comment.
Yes, it's quite weird. I remember we removed some binaries from the repo and that re-wrote history. Could that be related?
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #1238 +/- ##
========================================
Coverage 57.62% 57.62%
========================================
Files 1066 1066
Lines 27677 27677
Branches 5713 5713
========================================
Hits 15948 15948
Misses 9244 9244
Partials 2485 2485 ☔ View full report in Codecov by Sentry. |
|
|
Ok, Sonar CI times are back to 10-15min, instead of 35-60min. |
|
About the 2 vulnerabilities, they are false positives as we know they exist and the keys mentioned are intentionally public, right? EDIT: it's confirmed they're false positives, they've been addressed in Sonar. |
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Just to confirm, the work-around is not needed anymore?
There was a problem hiding this comment.
They recently added support for KMP source sets, so I'd be really surprised if they didn't support the default Kotlin ones 😅 . But yes, the analysis seems to be working fine after removing these lines. I couldn't find where this support was added though.
gradle/libs.versions.toml
Outdated
| @@ -203,6 +203,6 @@ dependencygraph = { id = "com.savvasdalkitsis.module-dependency-graph", version. | |||
| dependencycheck = { id = "org.owasp.dependencycheck", version.ref = "dependencycheck" } | |||
| dependencyanalysis = { id = "com.autonomousapps.dependency-analysis", version.ref = "dependencyanalysis" } | |||
| paparazzi = "app.cash.paparazzi:1.3.1" | |||
| sonarqube = "org.sonarqube:4.3.1.3277" | |||
| sonarqube = "org.sonarqube:4.2.1.3168" | |||
There was a problem hiding this comment.
Maybe add a comment above that 4.3.1.3277 is problematic, because Renovate will try to upgrade again.
|
Kudos, SonarCloud Quality Gate passed!
|
Type of change
Content
Fix duplicate Sonar scanner job, and hopefully the very long run times.
Motivation and context
Sonar is running twice in the CI and it's become super slow.
Checklist