Skip to content

Feature/bma/link in topic #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Feature/bma/link in topic #1237

merged 2 commits into from
Sep 6, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 6, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Make link in room topics clickable

Motivation and context

Fixes #612

Screenshots / GIFs

Include in the PR

Tests

  • Add a link to a room topic
  • Click on the link from the room detail page
  • The link is opened in the external browser

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner September 6, 2023 13:52
@bmarty bmarty requested review from jmartinesp and removed request for a team September 6, 2023 13:52
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/rC2D7t

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@bmarty bmarty merged commit a40c9ef into develop Sep 6, 2023
@bmarty bmarty deleted the feature/bma/linkInTopic branch September 6, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links in room topic should be clickable in room detail view
2 participants