Skip to content

Enable polls #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Enable polls #1196

merged 1 commit into from
Aug 31, 2023

Conversation

julioromano
Copy link

@julioromano julioromano commented Aug 31, 2023

Enable the Polls feature. Allows to create, view, vote and end polls.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/tWwMbF

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (199f578) 57.29% compared to head (0bc85b3) 57.28%.
Report is 1 commits behind head on develop.

❗ Current head 0bc85b3 differs from pull request most recent head 361ce1b. Consider uploading reports for the commit 361ce1b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1196      +/-   ##
===========================================
- Coverage    57.29%   57.28%   -0.01%     
===========================================
  Files         1044     1044              
  Lines        27207    27206       -1     
  Branches      5606     5606              
===========================================
- Hits         15587    15586       -1     
  Misses        9191     9191              
  Partials      2429     2429              
Files Changed Coverage Δ
.../android/libraries/featureflag/api/FeatureFlags.kt 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julioromano julioromano self-assigned this Aug 31, 2023
@julioromano julioromano marked this pull request as ready for review August 31, 2023 09:51
@julioromano julioromano requested a review from a team as a code owner August 31, 2023 09:51
@julioromano julioromano requested review from jmartinesp and removed request for a team August 31, 2023 09:51
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a changelog file could be included, since this small PR actually enable a new feature in the app. So we have to let the users know.

@julioromano julioromano force-pushed the julioromano/polls_enable branch from 0bc85b3 to 361ce1b Compare August 31, 2023 12:47
@julioromano julioromano enabled auto-merge (squash) August 31, 2023 12:48
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@julioromano julioromano merged commit 33683ab into develop Aug 31, 2023
@julioromano julioromano deleted the julioromano/polls_enable branch August 31, 2023 13:17
@bmarty bmarty mentioned this pull request Sep 7, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants