PollCreate: Focus on question field when opening screen. #1194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1194 +/- ##
===========================================
+ Coverage 57.28% 57.29% +0.01%
===========================================
Files 1044 1044
Lines 27182 27192 +10
Branches 5603 5603
===========================================
+ Hits 15570 15580 +10
Misses 9184 9184
Partials 2428 2428
☔ View full report in Codecov by Sentry. |
julioromano
force-pushed
the
julioromano/pollcreate_focus
branch
from
b9206af to
3ae9d17
Compare
|
Kudos, SonarCloud Quality Gate passed! |
bmarty
approved these changes
Aug 31, 2023
| @@ -68,6 +75,10 @@ fun CreatePollView( | |||
| onSubmitClicked = { state.eventSink(CreatePollEvents.NavBack) }, | |||
| onDismiss = { state.eventSink(CreatePollEvents.HideConfirmation) } | |||
| ) | |||
| val questionFocusRequester = remember { FocusRequester() } | |||
There was a problem hiding this comment.
As a remark, there are other usage of FocusRequester() in teh codebase, by we never used remember for them. I guess we should do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.