Skip to content

Rename file and update tosUri value. #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Aug 30, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Provide client image url and fix tos url.

Note: client image url has been provided in a commit outside of this PR (when upgrading the Rust SDK library) at 33ecfd3

Also rename the file for code clarity.

Motivation and context

Closes #1185

Screenshots / GIFs

Image is working (used by the Web service):

image

And clicking on the link terms of service is working.

Tests

  • Sign in using OIDC, for instance with an element.io account. Note: you may have to delete the app data to see the effect.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner August 30, 2023 14:58
@bmarty bmarty requested review from julioromano and removed request for a team August 30, 2023 14:58
@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/FYYyao

@bmarty bmarty enabled auto-merge August 30, 2023 15:08
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bmarty bmarty merged commit a435d3a into develop Aug 30, 2023
@bmarty bmarty deleted the feature/bma/oidcSmallChange branch August 30, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OIDC iteration
2 participants