Skip to content

Fix test compilation #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Fix test compilation #1183

merged 1 commit into from
Aug 30, 2023

Conversation

Florian14
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other: Fix build because of a deleted parameter

Content

Deleted votes parameter which does not exists anymore

Motivation and context

Fix broken develop: https://github.com/vector-im/element-x-android/actions/runs/6021403562/job/16334208533

@Florian14 Florian14 requested a review from a team as a code owner August 30, 2023 06:57
@Florian14 Florian14 requested review from julioromano and removed request for a team August 30, 2023 06:57
@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/vYqYe2

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@Florian14 Florian14 enabled auto-merge (rebase) August 30, 2023 07:05
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.14% 🎉

Comparison is base (bb75539) 57.12% compared to head (96affd7) 57.26%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1183      +/-   ##
===========================================
+ Coverage    57.12%   57.26%   +0.14%     
===========================================
  Files         1044     1044              
  Lines        27088    27093       +5     
  Branches      5592     5592              
===========================================
+ Hits         15473    15516      +43     
+ Misses        9193     9152      -41     
- Partials      2422     2425       +3     
Files Changed Coverage Δ
.../factories/event/TimelineItemContentPollFactory.kt 91.42% <ø> (+83.09%) ⬆️
...pl/timeline/model/event/TimelineItemPollContent.kt 100.00% <ø> (ø)
...ine/model/event/TimelineItemPollContentProvider.kt 100.00% <ø> (ø)
.../element/android/libraries/matrix/test/TestData.kt 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Florian14 Florian14 merged commit 0b88dac into develop Aug 30, 2023
@Florian14 Florian14 deleted the misc/fre/fix_build branch August 30, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants