Make sure Snackbars are only displayed once #1175
Conversation
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1175 +/- ##
===========================================
- Coverage 56.87% 56.86% -0.01%
===========================================
Files 1039 1039
Lines 26812 26817 +5
Branches 5544 5549 +5
===========================================
+ Hits 15248 15250 +2
+ Misses 9168 9167 -1
- Partials 2396 2400 +4
☔ View full report in Codecov by Sentry. |
| data class SnackbarMessage( | ||
| /** The message to be displayed. */ |
There was a problem hiding this comment.
Shouldn't these lines go in the class's docstring?
| fun clear() { | ||
| if (snackBarMessageQueue.isNotEmpty()) { | ||
| snackBarMessageQueue.removeFirstOrNull() | ||
| if (queueMutex.isLocked) queueMutex.unlock() |
There was a problem hiding this comment.
I am wondering if it would be useful to add some unit test to cover this.
There was a problem hiding this comment.
True, it should be easier to test now.
|
Kudos, SonarCloud Quality Gate passed! |
Type of change
Content
SnackbarDispatcher.snackbarMessagea Flow backed by a queue.SnackbarMessage.isDisplayedproperty to check if the message is already being displayed.SnackbarDispatcherqueue too when the coroutine displaying the current message is cancelled.Motivation and context
Fixes #928.
Tests
In an unverified session:
An alternative test is to go to your home screen and then back to the app.
Tested devices
Checklist