[Polls] Add unit tests for TimelineItemContentPollFactory

[Florian14]

Type of change

• Feature
• Bugfix
• Technical
• Other : add missing tests

Content

Add unit tests for TimelineItemContentPollFactory.

Motivation and context

Ensure the TimelineItemContentPollFactory produces the expected UI models from a PollContent.
Check that correct answers are detected as winners and that votes are only disclosed when they are supposed to be.

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/YteP46

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.14% 🎉

Comparison is base (5a85459) 56.87% compared to head (992050c) 57.01%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1161      +/-   ##
===========================================
+ Coverage    56.87%   57.01%   +0.14%     
===========================================
  Files         1039     1039              
  Lines        26812    26817       +5     
  Branches      5544     5544              
===========================================
+ Hits         15248    15291      +43     
+ Misses        9168     9127      -41     
- Partials      2396     2399       +3     

Files Changed	Coverage Δ
.../factories/event/TimelineItemContentPollFactory.kt	91.42% <ø> (+83.09%)	⬆️
...pl/timeline/model/event/TimelineItemPollContent.kt	100.00% <ø> (ø)
...ine/model/event/TimelineItemPollContentProvider.kt	100.00% <ø> (ø)
.../element/android/libraries/matrix/test/TestData.kt	100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bmarty]

Thanks for adding tests on this area. Some non-blocking remarks.

[bmarty]

Nit: Instead of copying, maybe add more parameters with default values to the fun aPollContent? Same remark for aTimelineItemPollContent and aPollAnswerItem.

[Florian14]

Done, I tried to factorize a bit. I chose to duplicate the parameters to have a better view of the initial state and the resulting state at the same time.
Let me know if you prefer this format. I could not find a way to deduplicate the expected results since there are some differences on each test case :/

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[bmarty]

Thanks for the update!