Cleanup OIDC

[bmarty]

Take into account comment from #1127 PR
Add a workaround to prevent user from getting stuck on a disabled "Continue" button.

(manually assigned to @jmartinesp for the follow up on #1127)

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/xzWCxB

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[codecov]

Codecov Report

Patch coverage: 66.66% and no project coverage change.

Comparison is base (14c568d) 57.10% compared to head (26e5da9) 57.10%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1128   +/-   ##
========================================
  Coverage    57.10%   57.10%           
========================================
  Files         1023     1023           
  Lines        26243    26243           
  Branches      5309     5309           
========================================
  Hits         14987    14987           
  Misses        8946     8946           
  Partials      2310     2310           

Files Changed	Coverage Δ
...tures/preferences/impl/root/PreferencesRootView.kt	61.76% <ø> (ø)
...ement/android/libraries/matrix/api/MatrixClient.kt	100.00% <ø> (ø)
...roid/features/logout/api/LogoutPreferenceScreen.kt	22.22% <33.33%> (+2.22%)	⬆️
...accountprovider/ConfirmAccountProviderPresenter.kt	87.93% <100.00%> (-0.21%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmartinesp]

Why the 5s delay here?

[bmarty]

This is sort of a compromise... If we wait more, the user will see a disabled button for a longer time.
If we wait less, we take the risk to cancel the login operation (the request to the homeserver with the Oidc token) before it finishes. The request does not take a long time, so maybe 2s is enough, but I did not want to take the risk.

The solution is not ideal, maybe we could try to detect that no OidcAction has been triggered (this should happen quite faster) and if this is the case we can cancel faster. I will think again about it.

[jmartinesp]

LGTM, thanks!