Skip to content

Fix sent videos being cropped #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

jmartinesp
Copy link
Member

Changes

  • Adds a video compression strategy of at most 1920x1080 (or 1080x1920), matching iOS.

Why

Apparently, passing no strategy results in the video being cropped.

Fixes #862.

@jmartinesp jmartinesp requested a review from a team as a code owner August 23, 2023 11:35
@jmartinesp jmartinesp requested review from Florian14 and removed request for a team August 23, 2023 11:35
@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/EMc5f7

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (2910911) 57.10% compared to head (7c27ac7) 57.09%.
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1124      +/-   ##
===========================================
- Coverage    57.10%   57.09%   -0.01%     
===========================================
  Files         1021     1021              
  Lines        26120    26124       +4     
  Branches      5282     5282              
===========================================
  Hits         14916    14916              
- Misses        8896     8900       +4     
  Partials      2308     2308              
Files Changed Coverage Δ
...t/android/libraries/mediaupload/VideoCompressor.kt 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Florian14 Florian14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no issue on my side

@jmartinesp jmartinesp merged commit 648e2c3 into develop Aug 24, 2023
@jmartinesp jmartinesp deleted the fix/jme/862-video-sent-from-eax-are-cropped branch August 24, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video sent from EAX are cropped
2 participants