-
Notifications
You must be signed in to change notification settings - Fork 232
Improve list items: add lists to dialogs, rework ListItem
customizations
#1119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Create `ListItemContent`. - Create `ListItemStyle`. - Apply those to `ListItem` components. - Create helper list item components for checkboxes, switches, radio buttons.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
- Add `subtitle` to `AlertDialogContents`. - Fixes paddings and margins inside dialogs. - Extracts `ListOption`. - Adds documentation.
Kudos, SonarCloud Quality Gate passed! |
ListItem
customizations
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1119 +/- ##
===========================================
- Coverage 57.10% 56.87% -0.24%
===========================================
Files 1021 1030 +9
Lines 26122 26504 +382
Branches 5282 5449 +167
===========================================
+ Hits 14918 15073 +155
- Misses 8897 9061 +164
- Partials 2307 2370 +63
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Changes
ListItemContent
.ListItemStyle
.ListItem
components.