Skip to content

Improve list items: add lists to dialogs, rework ListItem customizations #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 24, 2023

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Aug 22, 2023

Changes

  • Create ListItemContent.
  • Create ListItemStyle.
  • Apply those to ListItem components.
  • Create helper list item components for checkboxes, switches, radio buttons.
  • Create single and multiple selection dialogs with embedded lists.
  • Create single and multiple selection list items that handle selection values using the dialogs.

- Create `ListItemContent`.
- Create `ListItemStyle`.
- Apply those to `ListItem` components.
- Create helper list item components for checkboxes, switches, radio buttons.
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/HqPfVg

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 22 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@jmartinesp jmartinesp changed the title Improve list items: Improve list items: add lists to dialogs, rework ListItem customizations Aug 23, 2023
@jmartinesp jmartinesp marked this pull request as ready for review August 23, 2023 10:28
@jmartinesp jmartinesp requested a review from a team as a code owner August 23, 2023 10:28
@jmartinesp jmartinesp requested review from bmarty and removed request for a team August 23, 2023 10:28
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage: 43.55% and project coverage change: -0.24% ⚠️

Comparison is base (93e3029) 57.10% compared to head (30e1c15) 56.87%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1119      +/-   ##
===========================================
- Coverage    57.10%   56.87%   -0.24%     
===========================================
  Files         1021     1030       +9     
  Lines        26122    26504     +382     
  Branches      5282     5449     +167     
===========================================
+ Hits         14918    15073     +155     
- Misses        8897     9061     +164     
- Partials      2307     2370      +63     
Files Changed Coverage Δ
...ies/designsystem/components/list/SwitchListItem.kt 0.00% <0.00%> (ø)
...aries/designsystem/theme/components/ListSection.kt 67.74% <ø> (ø)
...system/components/dialogs/SingleSelectionDialog.kt 14.81% <14.81%> (ø)
...stem/components/dialogs/MultipleSelectionDialog.kt 18.75% <18.75%> (ø)
...s/designsystem/components/list/CheckboxListItem.kt 29.41% <29.41%> (ø)
...esignsystem/components/list/RadioButtonListItem.kt 35.29% <35.29%> (ø)
...ystem/components/list/MultipleSelectionListItem.kt 39.02% <39.02%> (ø)
...nsystem/components/list/SingleSelectionListItem.kt 42.50% <42.50%> (ø)
...tem/theme/components/previews/DatePickerPreview.kt 71.42% <50.00%> (+2.19%) ⬆️
...tem/theme/components/previews/TimePickerPreview.kt 72.72% <50.00%> (+2.72%) ⬆️
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jmartinesp jmartinesp merged commit b326ca2 into develop Aug 24, 2023
@jmartinesp jmartinesp deleted the misc/jme/compound-improve-lists branch August 24, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants