Skip to content

Feature/bma/sender name bubble #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 18, 2023
Merged

Feature/bma/sender name bubble #1093

merged 3 commits into from
Aug 18, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Aug 18, 2023

Fixes #1033

@bmarty bmarty requested a review from a team as a code owner August 18, 2023 13:21
@bmarty bmarty requested review from jmartinesp and removed request for a team August 18, 2023 13:21
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/YoQPie

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6e55f2d) 57.02% compared to head (f6f1ab7) 57.03%.
Report is 17 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1093   +/-   ##
========================================
  Coverage    57.02%   57.03%           
========================================
  Files         1017     1017           
  Lines        25819    25823    +4     
  Branches      5182     5182           
========================================
+ Hits         14724    14728    +4     
  Misses        8821     8821           
  Partials      2274     2274           
Files Changed Coverage Δ
...es/messages/impl/timeline/TimelineStateProvider.kt 98.96% <100.00%> (+0.02%) ⬆️
...s/impl/timeline/components/TimelineItemEventRow.kt 54.58% <100.00%> (+0.20%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 9b02865 into develop Aug 18, 2023
@bmarty bmarty deleted the feature/bma/senderNameBubble branch August 18, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long display names wrap into the chat bubble
2 participants