Skip to content

Fix rendering of inline elements in list items in messages #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 18, 2023

Conversation

jmartinesp
Copy link
Member

When inline elements such as links were used inside list items, they were being added as block elements, and sometimes not even added at all, only as a line break with the list item marker.

Fixes #1090.

@jmartinesp jmartinesp requested a review from a team as a code owner August 18, 2023 11:31
@jmartinesp jmartinesp requested review from bmarty and removed request for a team August 18, 2023 11:31
@jmartinesp jmartinesp force-pushed the fix/jme/1090-inline-elements-in-list-items branch from 125b2f0 to 3d5604f Compare August 18, 2023 11:34
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/vcurPz

@jmartinesp jmartinesp force-pushed the fix/jme/1090-inline-elements-in-list-items branch from 8338d65 to 66440d8 Compare August 18, 2023 12:56
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jmartinesp jmartinesp enabled auto-merge (squash) August 18, 2023 13:06
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage: 35.71% and project coverage change: -0.06% ⚠️

Comparison is base (3142355) 57.02% compared to head (66440d8) 56.97%.
Report is 15 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1091      +/-   ##
===========================================
- Coverage    57.02%   56.97%   -0.06%     
===========================================
  Files         1017     1017              
  Lines        25819    25822       +3     
  Branches      5182     5182              
===========================================
- Hits         14724    14712      -12     
- Misses        8821     8837      +16     
+ Partials      2274     2273       -1     
Files Changed Coverage Δ
...ages/impl/timeline/components/html/HtmlDocument.kt 66.47% <30.76%> (-4.22%) ⬇️
.../impl/timeline/components/html/DocumentProvider.kt 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@jmartinesp jmartinesp merged commit 6a4a4eb into develop Aug 18, 2023
@jmartinesp jmartinesp deleted the fix/jme/1090-inline-elements-in-list-items branch August 18, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird formatting in bullet lists with long points
2 participants