Skip to content

org.gradle.jvmargs=-Xmx4g #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2023
Merged

org.gradle.jvmargs=-Xmx4g #1087

merged 1 commit into from
Aug 18, 2023

Conversation

julioromano
Copy link

I have to do it locally every time i checkout a branch. Perhaps it's best if we push this to origin.

I have to do it locally every time i checkout a branch. Perhaps it's best if we push this to origin.
@julioromano julioromano requested a review from a team as a code owner August 18, 2023 06:50
@julioromano julioromano requested review from ganfra and removed request for a team August 18, 2023 06:50
@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/HrrXXT

@jmartinesp
Copy link
Member

I think it's a good idea to bump the default value since it's too low for some tasks now (lint, tests sometimes), but you could just add this line to your ~/.gradle/gradle.properties and it will override the default one in the project too if I'm not mistaken.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2ae3584) 57.02% compared to head (9893e27) 57.02%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1087   +/-   ##
========================================
  Coverage    57.02%   57.02%           
========================================
  Files         1017     1017           
  Lines        25819    25819           
  Branches      5182     5182           
========================================
  Hits         14724    14724           
  Misses        8821     8821           
  Partials      2274     2274           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julioromano
Copy link
Author

I think it's a good idea to bump the default value since it's too low for some tasks now (lint, tests sometimes), but you could just add this line to your ~/.gradle/gradle.properties and it will override the default one in the project too if I'm not mistaken.

Is there any downside in bumping the one in origin too? The tests ran pretty fast in this PR.

@jmartinesp
Copy link
Member

Is there any downside in bumping the one in origin too? The tests ran pretty fast in this PR.

No, I'm ok with increasing the max heap size. Let's see it @ganfra agrees too.

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me!

@julioromano julioromano merged commit 6e55f2d into develop Aug 18, 2023
@julioromano julioromano deleted the julioromano/gradle4g branch August 18, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants