Skip to content

Add feature flag for polls #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Aug 16, 2023
Merged

Add feature flag for polls #1064

merged 27 commits into from
Aug 16, 2023

Conversation

Florian14
Copy link
Contributor

@Florian14 Florian14 commented Aug 16, 2023

Add a feature flag in the developer settings for Polls feature

image

@Florian14 Florian14 marked this pull request as ready for review August 16, 2023 13:03
@Florian14 Florian14 requested a review from a team as a code owner August 16, 2023 13:03
@Florian14 Florian14 requested review from ganfra and removed request for a team August 16, 2023 13:03
@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/x4onxo

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remark otherwise LGTM

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 58.64% and no project coverage change.

Comparison is base (efdfe15) 56.89% compared to head (ff4703b) 56.90%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #1064    +/-   ##
=========================================
  Coverage    56.89%   56.90%            
=========================================
  Files          999     1014    +15     
  Lines        25438    25750   +312     
  Branches      5123     5188    +65     
=========================================
+ Hits         14474    14652   +178     
- Misses        8713     8816   +103     
- Partials      2251     2282    +31     
Files Changed Coverage Δ
...ndroid/features/messages/impl/MessagesPresenter.kt 82.69% <0.00%> (-0.54%) ⬇️
...eatures/messages/impl/actionlist/ActionListView.kt 58.77% <0.00%> (-0.26%) ⬇️
...meline/components/event/TimelineItemContentView.kt 72.91% <0.00%> (-6.63%) ⬇️
...tils/messagesummary/MessageSummaryFormatterImpl.kt 46.66% <0.00%> (-3.34%) ⬇️
...ndroid/features/poll/impl/DefaultPollEntryPoint.kt 0.00% <0.00%> (ø)
...tformatter/impl/DefaultRoomLastMessageFormatter.kt 95.16% <0.00%> (-1.57%) ⬇️
...entformatter/impl/DefaultTimelineEventFormatter.kt 0.00% <0.00%> (ø)
...s/featureflag/impl/BuildtimeFeatureFlagProvider.kt 0.00% <0.00%> (ø)
...ies/matrix/api/timeline/item/event/EventContent.kt 84.73% <0.00%> (-6.26%) ⬇️
...t/android/libraries/matrix/impl/poll/PollAnswer.kt 0.00% <0.00%> (ø)
... and 25 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from feature/fre/poll_event_timeline_rendering to develop August 16, 2023 14:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Florian14 Florian14 added this pull request to the merge queue Aug 16, 2023
Merged via the queue into develop with commit 41d0d21 Aug 16, 2023
@Florian14 Florian14 deleted the feature/fre/poll_feature_flag branch August 16, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants