Feature/fga/rust sdk tracing #1036
Conversation
| val tracingConfiguration = if (BuildConfig.DEBUG) { | ||
| TracingConfiguration( | ||
| filterConfiguration = TracingFilterConfigurations.debug, | ||
| writesToStdout = false, |
There was a problem hiding this comment.
Why is this false in both cases? I expected it to be true so the lines are displayed in the logcat output and not just written to the log files.
There was a problem hiding this comment.
Its always logging to logcat... I asked for a flag for logcat, but rust team removed it...
There was a problem hiding this comment.
I guess it's a special case for iOS? I remember they mentioned something about using stderr and it seems like setting this to true pipes the output to stderr.
There was a problem hiding this comment.
Maybe ? We don't need it on our side. What do you think about not logging to logcat in release ?
There was a problem hiding this comment.
As long as we have those log messages written to our log files I guess it's ok.
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Kudos, SonarCloud Quality Gate passed! |
Use the new rust api for tracing :
Timber.Treedelegating tolog_eventTracingConfigurationso we can directly log to files from the rustTested on a local version of the rust sdk, waiting for matrix-org/matrix-rust-sdk#2384