Fix sending read receipts when entering a room

[jmartinesp]

The callback in TimelineScrollHelper was only called when the timeline items were empty, so no initial read receipt was sent anymore.

Instead, we're sending a read receipt when the initial items for the timeline are loaded.

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/gnyDci

[jmartinesp]

I'm not too happy with this solution, but I can't really think of anything better right now.

[codecov]

Codecov Report

Patch coverage: 21.42% and project coverage change: -0.01% ⚠️

Comparison is base (62a3675) 56.91% compared to head (8df34f4) 56.91%.
Report is 3 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1016      +/-   ##
===========================================
- Coverage    56.91%   56.91%   -0.01%     
===========================================
  Files          993      993              
  Lines        25265    25268       +3     
  Branches      5115     5114       -1     
===========================================
+ Hits         14380    14381       +1     
- Misses        8615     8617       +2     
  Partials      2270     2270              

Files Changed	Coverage Δ
...ies/matrix/impl/notification/NotificationMapper.kt	0.00% <0.00%> (ø)
...atrix/impl/notification/RustNotificationService.kt	0.00% <0.00%> (ø)
...cation/TimelineEventToNotificationContentMapper.kt	0.00% <0.00%> (ø)
...droid/libraries/matrix/impl/room/RustMatrixRoom.kt	0.00% <0.00%> (ø)
...id/features/messages/impl/timeline/TimelineView.kt	45.00% <66.66%> (+0.34%)	⬆️
...atures/messages/impl/timeline/TimelinePresenter.kt	90.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmartinesp]

The implementation at ad4bc79, while simpler, makes it impossible to unit test the presenter properly, so I'll have to revert it...

[jmartinesp]

@ganfra In the end I've done a simpler implementation than the initial one, but keeping the same logic. Moving sending the read receipt for the initial items to the presenter made sense, but it made most of the logic associated with OnScrollFinished untestable.

[ganfra]

One remark, otherwise makes sense.
But I also encounter another issue, maybe it should handled by the sdk, but if the latest events are hidden (like reactions or edit events), the has unread won't be updated properly neither.

[ganfra]

Remove the code?

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication