-
Notifications
You must be signed in to change notification settings - Fork 232
Update dependency org.matrix.rustcomponents:sdk-android to v0.1.38 #1015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
These are not the droids you're looking for
e2345c1
to
2aeb40f
Compare
private fun NotificationItem.timestamp(): Long? { | ||
return (this.event as? NotificationEvent.Timeline)?.event?.timestamp()?.toLong() | ||
private fun NotificationItem.timestamp(clock: SystemClock): Long { | ||
// FIXME we can't get the timestamp from the notification item anymore, so we need to fake it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly, we're going to have to fallback to the current device's system time, as we don't have access to the timestamp anymore. I've asked the Rust team to retrieve it for NotificationEvent.Timeline
items too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say yes
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1015 +/- ##
===========================================
- Coverage 56.89% 56.88% -0.01%
===========================================
Files 990 990
Lines 25217 25219 +2
Branches 5109 5108 -1
===========================================
Hits 14347 14347
- Misses 8604 8606 +2
Partials 2266 2266
☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
This PR contains the following updates:
0.1.37
->0.1.38
⚠ Dependency Lookup Warnings ⚠
Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.