Skip to content

Update dependency org.matrix.rustcomponents:sdk-android to v0.1.38 #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 1, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.matrix.rustcomponents:sdk-android 0.1.37 -> 0.1.38 age adoption passing confidence

⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner August 1, 2023 05:38
@renovate renovate bot requested review from julioromano and removed request for a team August 1, 2023 05:38
@renovate renovate bot added the PR-Dependencies Pull requests that update a dependency file label Aug 1, 2023
@ElementBot
Copy link
Collaborator

ElementBot commented Aug 1, 2023

Warnings
⚠️

gradle/libs.versions.toml#L6 - A newer version of com.android.tools.build:gradle than 8.0.2 is available: 8.1.0

⚠️

gradle/libs.versions.toml#L26 - A newer version of androidx.compose.compiler:compiler than 1.4.8 is available: 1.5.1

⚠️

gradle/libs.versions.toml#L92 - A newer version of androidx.preference:preference than 1.2.0 is available: 1.2.1

Generated by 🚫 dangerJS against 2d758ab

julioromano
julioromano previously approved these changes Aug 1, 2023
@julioromano julioromano requested review from julioromano and ganfra and removed request for julioromano August 1, 2023 06:48
@julioromano julioromano dismissed their stale review August 1, 2023 07:36

These are not the droids you're looking for

@jmartinesp jmartinesp requested review from julioromano and removed request for julioromano August 1, 2023 07:40
@jmartinesp jmartinesp force-pushed the renovate/org.matrix.rustcomponents branch from e2345c1 to 2aeb40f Compare August 1, 2023 09:30
private fun NotificationItem.timestamp(): Long? {
return (this.event as? NotificationEvent.Timeline)?.event?.timestamp()?.toLong()
private fun NotificationItem.timestamp(clock: SystemClock): Long {
// FIXME we can't get the timestamp from the notification item anymore, so we need to fake it
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, we're going to have to fallback to the current device's system time, as we don't have access to the timestamp anymore. I've asked the Rust team to retrieve it for NotificationEvent.Timeline items too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say yes

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link:

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (b14c741) 56.89% compared to head (2d758ab) 56.88%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1015      +/-   ##
===========================================
- Coverage    56.89%   56.88%   -0.01%     
===========================================
  Files          990      990              
  Lines        25217    25219       +2     
  Branches      5109     5108       -1     
===========================================
  Hits         14347    14347              
- Misses        8604     8606       +2     
  Partials      2266     2266              
Files Changed Coverage Δ
...ies/matrix/impl/notification/NotificationMapper.kt 0.00% <0.00%> (ø)
...atrix/impl/notification/RustNotificationService.kt 0.00% <0.00%> (ø)
...cation/TimelineEventToNotificationContentMapper.kt 0.00% <0.00%> (ø)
...droid/libraries/matrix/impl/room/RustMatrixRoom.kt 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmartinesp jmartinesp added this pull request to the merge queue Aug 1, 2023
@renovate
Copy link
Contributor Author

renovate bot commented Aug 1, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

Merged via the queue into develop with commit 9bc336d Aug 1, 2023
@jmartinesp jmartinesp deleted the renovate/org.matrix.rustcomponents branch August 1, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants