Skip to content

Fix detekt issues in develop #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Fix detekt issues in develop #1004

merged 2 commits into from
Jul 31, 2023

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Jul 31, 2023

FIx some detekt issues in develop after changing the lint rules.

@jmartinesp jmartinesp marked this pull request as ready for review July 31, 2023 10:47
@jmartinesp jmartinesp requested a review from a team as a code owner July 31, 2023 10:48
@jmartinesp jmartinesp requested review from bmarty, a team and julioromano and removed request for a team and bmarty July 31, 2023 10:48
@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link:

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 47.14% and project coverage change: +0.05% 🎉

Comparison is base (39bd0b9) 56.69% compared to head (49eaacc) 56.74%.
Report is 61 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1004      +/-   ##
===========================================
+ Coverage    56.69%   56.74%   +0.05%     
===========================================
  Files          983      983              
  Lines        24909    24949      +40     
  Branches      5060     5076      +16     
===========================================
+ Hits         14121    14157      +36     
- Misses        8545     8547       +2     
- Partials      2243     2245       +2     
Files Changed Coverage Δ
...o/element/android/appnav/LoggedInEventProcessor.kt 0.00% <0.00%> (ø)
...io/element/android/appnav/loggedin/LoggedInView.kt 63.63% <0.00%> (ø)
...o/element/android/appnav/loggedin/SyncStateView.kt 43.75% <0.00%> (ø)
...element/android/appnav/room/LoadingRoomNodeView.kt 59.52% <ø> (ø)
...lytics/api/preferences/AnalyticsPreferencesView.kt 58.82% <ø> (ø)
...roid/features/analytics/impl/AnalyticsOptInView.kt 65.95% <ø> (ø)
...es/createroom/impl/components/RoomPrivacyOption.kt 84.00% <ø> (ø)
...ent/android/features/location/api/StaticMapView.kt 50.00% <0.00%> (ø)
...ures/location/api/internal/StaticMapPlaceholder.kt 77.14% <ø> (ø)
...id/features/location/impl/send/SendLocationView.kt 57.85% <ø> (ø)
... and 88 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
26.6% 26.6% Duplication

}
}
else -> break
Event.Complete, is Event.Error -> foundItemOrFinished = true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow now I can understand this code too! :)

@julioromano julioromano added this pull request to the merge queue Jul 31, 2023
@jmartinesp jmartinesp removed this pull request from the merge queue due to a manual request Jul 31, 2023
@jmartinesp jmartinesp merged commit eb80f5b into develop Jul 31, 2023
@jmartinesp jmartinesp deleted the julioromano/fix_develop branch July 31, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants