Skip to content

Update dependency io.nlopez.compose.rules:detekt to v0.2.1 #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 30, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
io.nlopez.compose.rules:detekt 0.1.12 -> 0.2.1 age adoption passing confidence

⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.


Release Notes

mrmans0n/compose-rules (io.nlopez.compose.rules:detekt)

v0.2.1

Changelog

v0.2.0

Changelog

  • Add rule to ensure modifiers are used at the top-most composable (#​83) @​mrmans0n
  • Add rule to have ComponentDefaults objects matching the visibility of their composables (#​82) @​mrmans0n
  • Add a rule to enforce correct naming of Modifier parameters (#​81) @​mrmans0n
  • Detect all vm forwarding violations regardless of nesting level (#​80) @​mrmans0n

v0.1.13

Changelog


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner July 30, 2023 12:06
@renovate renovate bot requested review from bmarty and removed request for a team July 30, 2023 12:06
@renovate renovate bot added the PR-Dependencies Pull requests that update a dependency file label Jul 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/kYfe5p

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9e1ff51) 56.89% compared to head (a3ae891) 56.90%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1001   +/-   ##
========================================
  Coverage    56.89%   56.90%           
========================================
  Files          999      999           
  Lines        25438    25440    +2     
  Branches      5123     5124    +1     
========================================
+ Hits         14474    14476    +2     
  Misses        8713     8713           
  Partials      2251     2251           
Files Changed Coverage Δ
...ent/android/features/location/api/StaticMapView.kt 50.98% <100.00%> (+0.98%) ⬆️
...ures/location/api/internal/StaticMapPlaceholder.kt 77.14% <100.00%> (ø)
...ssages/impl/messagecomposer/MessageComposerView.kt 53.33% <100.00%> (-1.51%) ⬇️
...s/roomdetails/impl/invite/RoomInviteMembersView.kt 48.21% <100.00%> (+0.46%) ⬆️
...res/roomdetails/impl/members/RoomMemberListView.kt 56.89% <100.00%> (+0.37%) ⬆️
...mlist/impl/components/RequestVerificationHeader.kt 89.18% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot changed the title Update dependency io.nlopez.compose.rules:detekt to v0.1.13 Update dependency io.nlopez.compose.rules:detekt to v0.2.0 Aug 9, 2023
@renovate renovate bot force-pushed the renovate/io.nlopez.compose.rules-detekt-0.x branch from cf54948 to 61f7fd5 Compare August 9, 2023 12:38
@renovate renovate bot changed the title Update dependency io.nlopez.compose.rules:detekt to v0.2.0 Update dependency io.nlopez.compose.rules:detekt to v0.2.1 Aug 9, 2023
@renovate renovate bot force-pushed the renovate/io.nlopez.compose.rules-detekt-0.x branch from 61f7fd5 to aa62ac0 Compare August 9, 2023 21:53
@renovate renovate bot force-pushed the renovate/io.nlopez.compose.rules-detekt-0.x branch from aa62ac0 to f138f7c Compare August 16, 2023 12:42
@bmarty
Copy link
Member

bmarty commented Aug 16, 2023

Assigning to someone else, to check my changes fixing new "detekted" issues.

@bmarty bmarty requested review from a team and jmartinesp and removed request for bmarty and a team August 16, 2023 13:26
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Surface(
modifier.fillMaxWidth(),
Modifier.fillMaxWidth(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to myself: I will double check that the banner is still displayed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, it's displayed, but I have to go back to the home screen and restart the app after a login to see the banner, and it's the same to see the "Complete verification" item in the settings, so this is not something new introduced by this change.

@renovate
Copy link
Contributor Author

renovate bot commented Aug 16, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bmarty bmarty merged commit b44dde4 into develop Aug 17, 2023
@bmarty bmarty deleted the renovate/io.nlopez.compose.rules-detekt-0.x branch August 17, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants