Skip to content

Revert "Update the mobile_guide page to the new design." #30104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

Revert "Update the mobile_guide page to the new design." #30104

merged 1 commit into from
Jun 10, 2025

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jun 10, 2025

@t3chguy t3chguy added the T-Task Tasks for the team like planning label Jun 10, 2025
@t3chguy t3chguy marked this pull request as ready for review June 10, 2025 13:01
@t3chguy t3chguy requested a review from a team as a code owner June 10, 2025 13:01
@t3chguy t3chguy requested review from dbkr and MidhunSureshR June 10, 2025 13:01
@t3chguy t3chguy merged commit c51823d into develop Jun 10, 2025
44 of 45 checks passed
@t3chguy t3chguy deleted the revert-30006-doug/mobile-guide branch June 10, 2025 13:01
pixlwave added a commit to pixlwave/element-web that referenced this pull request Jun 19, 2025
@pixlwave
Reapply "Update the mobile_guide page to the new design. (element-hq#…
2e6b385 
…30006)" (element-hq#30104)

This reverts commit c51823d.
@pixlwave pixlwave mentioned this pull request Jun 19, 2025
Merged
snowping pushed a commit to Novaloop-AG/element-web that referenced this pull request Jun 22, 2025
@t3chguy @snowping
Revert "Update the mobile_guide page to the new design. (element-hq#3…
5d9e164 
…0006)" (element-hq#30104)
github-merge-queue bot pushed a commit that referenced this pull request Jul 3, 2025
@pixlwave @t3chguy
Update the mobile_guide page to the new design and link out to Elemen…
90f4d34 
…t X by default. (#30172)

* Reapply "Update the mobile_guide page to the new design. (#30006)" (#30104)

This reverts commit c51823d.

* Use Element X as the default mobile_guide_app_variant when omitted.

* Fix a build error on Windows.

Additionally revert "Remove unnecessary <%= require %> usages" and let webpack handle all of the assets (without a manual copy rule).

* Exclude mobile_guide from coverage gate

It has playwright tests

* Revert the re-introduction of <%= require %>

* Fix snapshot tests on mobile_guide.

---------

Co-authored-by: Michael Telatynski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from element-hq/element-web-reviewers

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@t3chguy