Skip to content

Handle errors returned from Seshat #30083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

Handle errors returned from Seshat #30083

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2691090
Handle errors returned from Seshat
richvdh Jun 4, 2025
c6909c4
fix type casting
richvdh Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/vector/platform/IPCManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { type ElectronChannel } from "../../@types/global";

interface IPCPayload {
id?: number;
error?: string;
error?: string | { message: string };
reply?: any;
}

Expand Down Expand Up @@ -53,7 +53,12 @@ export class IPCManager {
const callbacks = this.pendingIpcCalls[payload.id];
delete this.pendingIpcCalls[payload.id];
if (payload.error) {
callbacks.reject(payload.error);
// `seshat.ts` sends a JavaScript object with a `message` property. Turn it into a proper Error.
let error = payload.error;
if (typeof error === "object" && error.message) {
error = new Error(error.message);
}
callbacks.reject(error);
} else {
callbacks.resolve(payload.reply);
}
Expand Down
Loading