Fix a test of SetupEncryptionToast #29888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
andybalaam/tweak-setupencryptiontoast-tests
to
develop
May 6, 2025 14:53
andybalaam
force-pushed
the
andybalaam/fix-incorrect-test
branch
from
3eb097d to
51ffa58
Compare
florianduros
approved these changes
May 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
parsatorb
pushed a commit
to iluvatar-tech/element-web
that referenced
this pull request
May 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #29231
Fix a test that only passes when run in the right sequence with other tests, because it actually asserts something that happens in another test.
Adjust the test setup so the tests are independent, and then fix the assertion to expect the behaviour we have in this case.