Cache the key backup status whether enabled or not #29886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkr
approved these changes
May 6, 2025
andybalaam
force-pushed
the
andybalaam/cache-key-backup-status-in-device-listener
branch
from
4c9550b to
bf0ca75
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
andybalaam
deleted the
andybalaam/cache-key-backup-status-in-device-listener
branch
parsatorb
pushed a commit
to iluvatar-tech/element-web
that referenced
this pull request
May 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #29231
Tidy up key backup status in
DeviceListenera little, making it easier to find out about key backup status, which we will do in later changes.Includes a small change to behaviour: always cache the answer, instead of only caching it when the answer was
true. I can't see a way that this will cause problems, but if the reviewer can, it is simple to change it back to only caching positive answers.