Skip to content

Use 'Dismiss' to close pinned identity changes, instead of 'Ok' #29569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

Use 'Dismiss' to close pinned identity changes, instead of 'Ok' #29569

merged 1 commit into from
Mar 24, 2025

Conversation

andybalaam
Copy link
Member

As specified in element-hq/element-meta#2792 , use "Dismiss" instead of "Ok" for this prompt, since the user has no other choice.

@andybalaam andybalaam requested a review from a team as a code owner March 21, 2025 15:24
@andybalaam andybalaam requested review from dbkr and florianduros March 21, 2025 15:24
@andybalaam andybalaam mentioned this pull request Mar 21, 2025
Closed
@andybalaam andybalaam added the T-Task Tasks for the team like planning label Mar 21, 2025
florianduros
florianduros approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit surprised that we don't need to update an jest test or an e2e test. It means that this component is never tested in snapshot test.

@andybalaam andybalaam added this pull request to the merge queue Mar 24, 2025
@andybalaam
Copy link
Member Author

I'm a bit surprised that we don't need to update an jest test or an e2e test. It means that this component is never tested in snapshot test.

Yeah, me too.

Merged via the queue into develop with commit d0c1610 Mar 24, 2025
42 of 43 checks passed
@andybalaam andybalaam deleted the andybalaam/tweak-identity-change-messages branch March 24, 2025 09:32
@andybalaam
Copy link
Member Author

I'm a bit surprised that we don't need to update an jest test or an e2e test. It means that this component is never tested in snapshot test.

Yeah, me too.

Ah, some tests broke here - I am on it https://github.com/element-hq/element-web/actions/runs/14028476737/job/39271314770?pr=29577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florianduros florianduros florianduros approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andybalaam @florianduros