Skip to content

Room search instructions are misleading with the new room header #29831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
denschub opened this issue Apr 28, 2025 · 0 comments · Fixed by #29850
Closed

Room search instructions are misleading with the new room header #29831

denschub opened this issue Apr 28, 2025 · 0 comments · Fixed by #29850
Assignees
@t3chguy
Labels
A-New-Search-Experience The new search dialog available in Labs A-Search O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@denschub
Copy link

Steps to reproduce

  1. Open the room search by clicking the "search" field or with cmd/ctrl+K
  2. Search for something that is not one of your rooms, like "foobardingdong4000" (probably)

Outcome

What did you expect?

The "other searches" section should explain how I can search for room messages.

What happened instead?

The "other searches" section shows

To search messages, look for this icon at the top of a room [magnifying glass icon]

Previously: #26781

The magnifying glass icon was still there in the old room header - but the new room header is out of labs and applies to everyone, so these instructions are now actively misleading and confusing.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@dosubot dosubot bot added A-New-Search-Experience The new search dialog available in Labs A-Search O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist labels Apr 28, 2025
@t3chguy t3chguy self-assigned this Apr 29, 2025
t3chguy added a commit that referenced this issue Apr 29, 2025
@t3chguy
Allow jumping to message search from spotlight
f776d6d 
replaces the message search hint which referenced the old UX

Fixes #29831

Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy mentioned this issue Apr 29, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 30, 2025
@t3chguy
Allow jumping to message search from spotlight (#29850)
4bf28f8 
* Allow jumping to message search from spotlight

replaces the message search hint which referenced the old UX

Fixes #29831

Signed-off-by: Michael Telatynski <[email protected]>

* Update RoomSummaryCard.tsx

* Update actions.ts

* Delete src/hooks/useTransition.ts

* Update RoomSummaryCard.tsx

* Iterate

Signed-off-by: Michael Telatynski <[email protected]>

* Iterate

Signed-off-by: Michael Telatynski <[email protected]>

* Iterate

Signed-off-by: Michael Telatynski <[email protected]>

* Add test

Signed-off-by: Michael Telatynski <[email protected]>

---------

Signed-off-by: Michael Telatynski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-New-Search-Experience The new search dialog available in Labs A-Search O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow jumping to message search from spotlight element-hq/element-web
2 participants
@denschub @t3chguy