Skip to content

Room list filters inconsistent with EX #29666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kongo09 opened this issue Apr 3, 2025 · 5 comments
Open

Room list filters inconsistent with EX #29666

kongo09 opened this issue Apr 3, 2025 · 5 comments
Assignees
Labels
A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement

Comments

@kongo09
Copy link

kongo09 commented Apr 3, 2025

Your use case

What would you like to do?

Filter the room list

Why would you like to do it?

Get quick access to the relevant rooms

How would you like to achieve it?

Use the filter pills above the room list

What do you expect?

Consistency between EX and Web

  • same copy, e.g. unreads vs. unread or favourites vs. favorites
  • same order from EX: unreads, people, rooms, favorites
  • same scope: EW missing invites
  • no linebreak in EW for narrow room lists
  • leading X to clear all filters

What do you experience?

Web

Image

Image

EX

Image

Image

Teams avoiding the linebreak by using a chevron

Image

Have you considered any alternatives?

No response

Additional context

No response

@dosubot dosubot bot added A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely labels Apr 3, 2025
@daniellekirkwood
Copy link
Contributor

Thanks, Patrick!

same copy, e.g. unreads vs. unread or favourites vs. favorites

Great catch, this should be really easy to fix Unread > Unreads. Will raise with team.
The spelling of Favourites should be British English (with the U) - we will need to raise that with the EX team.

same order from EX: unreads, people, rooms, favorites

Gaelle specifically asked that we have the filters on web in the order they are currently in because Unreads and Favourites are probably going to be the most used...

@amshakal I agree with PA that the filters should match in their order -- which is the cross-platform order we should go with?

same scope: EW missing invites

EX has an Invites filter? Does it only show when you have one?

no linebreak in EW for narrow room lists

EW does have a line break - it doesn't have the expansion like MS. Gaelle was very against this solution (I think Design was as a whole against this). @amshakal wdyt?

leading X to clear all filters

Similarly, Design didn't want to introduce the X on web, and then chose to implement single-select filters - I forget the reasons why but know they were discussed.

@MidhunSureshR
Copy link
Member

We have more filters (secondary) that are not yet exposed in the UI:

Image

@daniellekirkwood
Copy link
Contributor

The text has been changed.

We need a UX decision on whether to change the order of the pills to match on mobile, @amshakal / @americanrefugee wdyt?

@americanrefugee
Copy link

We need a UX decision on whether to change the order of the pills to match on mobile, @amshakal / @americanrefugee wdyt?

Yes, I think they should be ordered like on mobile.

@dbkr dbkr self-assigned this May 14, 2025
@dbkr dbkr mentioned this issue May 14, 2025
4 tasks
@dbkr
Copy link
Member

dbkr commented May 14, 2025

I've made #29666 for this, assuming design agree with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement
Projects
None yet
Development

No branches or pull requests

5 participants