Skip to content

Remove Modal.closeCurrentModal #27678

Closed
@dbkr

Description

@dbkr

Your use case

In matrix-org/matrix-react-sdk#12728 I essentially replaced this function with one that force-closes all the active modals, because this was actually what was intended in all the places it was called. However, making the test use it caused a bunch of them to start racing and breaking each other.

It would be great to remove the current hack in test utils that closes all dialogs and replace it with the force close method, de-racing the tests in the process.

Have you considered any alternatives?

No response

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-DialogsT-TaskTasks for the team like planning

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions