ID server access token not included when making a 3pid invite

[richvdh]

Steps to reproduce

Send an invite to a third-party id (eg an email address)

Outcome

What did you expect?

id_access_token should be included, since the spec requires it

What happened instead?

No id_access_token parameter

Operating system

No response

Application version

1.11.0

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No

[richvdh]

We're planning to drop support for 3pid invite requests (via both POST /_matrix/client/v3/rooms/{roomId}/invite and POST /_matrix/client/v3/createRoom) without an id_access_token, because we need to know that a user has accepted the IS'es terms before we use it (cf matrix-org/synapse#13206, matrix-org/sydent#338).

[turt2live]

so we have all the code which makes this work, but we forgot to copy the IdentityServerProvider over to the MatrixClient, so it thinks it doesn't need to supply an access token 🤦

[turt2live]

unclear when this regressed, but my guess would be when the file got converted to typescript

[richvdh]

Thanks for jumping on this so quickly @turt2live !