Settings keeps local settings overrides on logout

[dbkr]

Steps to reproduce

1. Change a setting (eg. 'allow peer to peer for 1:1 calls')
2. Log out
3. Log in again

Outcome

What did you expect?

Setting should be back at the default value

What happened instead?

Setting is still is whatever state you set it to before logging out

It looks like what is happening is that SettingsStore (presumably) is keeping the value around somewhere, so although we clear localstorage on logout, it puts the value back again when you log back in.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No