Skip to content

Inline Reactions should send if the emoji is fully formed, before it is converted #17171

Closed
matrix-org/matrix-react-sdk
#5659
@Esras

Description

@Esras

Problem

When typing an inline reaction (+:+1:, for example, to add a thumbs-up to the prior response from the keyboard), the inline reaction is only sent if the emoji encompassed in the colons is converted to emoji. If you type +:glad:, the emoji picker menu will open, and the correct emoji will show up in the picker, but unless you hit tab to select an emoji, then the message will simply be sent as another message in the chat.

Expected Behavior

Typing +:+1: should add a reaction to the prior message, regardless of whether or not it was replaced with the actual thumbs-up emoji.

In searching some other issues, I found #2838, which seems to be related to the auto-conversion of emoji-formatted messages like :glad: to 😃. It was closed as a dupe of #2802, which seems to relate to converting things like :) to 😃. There may be a deeper issue / question here related to this replacement.

Additional context

Related Issues:
#1357 - "Inline reactions that add on to messages"
#10282 - "Remove feature flags for reactions and edits"

Metadata

Metadata

Assignees

No one assigned

    Labels

    O-FrequentAffects or can be seen by most users regularly or impacts most users' first experienceS-MinorImpairs non-critical functionality or suitable workarounds existT-Enhancement

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions