Skip to content

"Voice call" button in group chats doesn't make full use of Integration Manager settings #11074

Closed
@mrjohnson22

Description

@mrjohnson22

Description

After having chosen a custom Integration Manager, Jitsi widgets created by the "Voice call" button in group chats may not use the correct Jitsi URL. This leads the Jitsi widget to not load.

Steps to reproduce

  • Log on to either riot.im/app, or a Riot/Web that uses the default integrations_ URLs in its config.json
  • Set a custom Integration Manager (a Dimension domain is recommended)
  • Enter/join a group chat and get permissions to add/edit widgets
  • Click the "Voice call" button

Result: A Jitsi widget appears, but it remains blank.

In contrast, Jitsi widgets created through the Integration Manager menu (the four-squares icon) work as expected.

Also, if config.json's integration_ URLs point to that of a custom Integration Mamager (in the case of Dimension, the URLs listed on its homepage), the problem goes away.

What appears to be the problem is the widget URL used by Riot when clicking on the "Voice call" button. The URL used is the following (non-working case):

https://<integration_manager_domain>/api/v1/scalar/widgets/jitsi.html

In contrast, after having edited config.json or using the Integration Manager menu, a Jitsi widget has the following URL (at least in the case of Dimension) (working case):

https://<integration_manager_domain>/widgets/jitsi

Also, only the latter case includes query parameters from the v2 Widget API, notably domain, in the widget URL. If possible, it should always be used, so that clients which load a Jitsi view directly (instead of a page with a button that redirects to a Jitsi page) can refer to the domain parameter to connect to Jitsi calls hosted at a non-default domain.

Version information

  • Platform: web
  • Browser: Firefox 69.0.2
  • OS: Fedora 30
  • URL: riot.im/app / private server
  • Riot/Web version v1.4.2

EDIT: the query parameter I meant was domain, not hostname.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions