Respect OS Do Not Disturb mode

[pepyakin]

Description

In macOS there is a special mode called "Do not disturb" (DND). It is designed for cases when you need to focus on something or you just merely need to disable all notifications (imagine being on a talk but still being connected to the internet). If you activate this mode apps become silent, all notifications are not shown, etc.

However, it seems like that the Riot macOS app doesn't respect this setting and still will produce sounds. This is not solvable with individual notification settings (basically there is too many people you actually want to keep notifications while not in DND) and it is awkward to disable all notifications settings because it is too easy to forget to turn them off and turn them off again only for one app.

Version information

MacOS 10.14.1
Version 0.17.6 (0.17.6)

[aaronraimist]

:/ I don't think Electron has a built in way to tell if DND is enabled. Looks like Electron recommends using this library https://github.com/felixrieseberg/electron-notification-state which only has one commit... maybe it's just really stable and good at it's current state?

[lampholder]

That felixrieseberg library just wraps two other libraries for fetching mac/windows notification states (also written by felixrieseberg, and with 7 and 9 commits respectively). Scanning the code it does look feasible that it might just work?

[yajo]

As explained in element-hq/element-web#13941, the same happens in linux.

[Half-Shot]

The Do Not Disturb mode on gnome is the dconf setting /org/gnome/desktop/notifications/show-banners. Element notifs should already be blocked by the setting, but sounds won't be. We will need to find a library that allows us to listen on dbus for when this value is updated.

[Half-Shot]

#133 should hopefully address folks on GNOME

[otheus]

Just to be clear, the preferred way on MacOS is to use the notifications API, so that do-not-disturb mode and other OS behavior is consistent.

[t3chguy]

Electron does not support accessing that API seemingly, but closest we can get is to try and read the DND state using https://www.electronjs.org/docs/tutorial/notifications#do-not-disturb--session-state

[pepyakin]

Op here. FWIW, for me this was solved by migrating to the web version, to PWA app within Chrome to be exact.