Send notification events when starting a call #3248
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this has been the responsibility of the hosting application (Element Web / Element X), but I would like to move this responsibility to Element Call itself to make it even more lightweight to integrate Element Call into a widget-capable client.
robintown
added
the
PR-Feature
|
I remember the idea being that this is part of the hosting application is that we can have different behaviours on mobile vs desktop and that we might introduce custom ui to send a ring/notify call. |
|
I think we would still have the opportunity to do that, as the widget here gets to decide the notification behavior at the point that it enters the session, and the hosting application can always give extra context to the widget about how it's being used (intent etc.) through the URL params |
toger5
reviewed
May 14, 2025
| import { MatrixRTCFocusMissingError } from "./utils/errors.ts"; | ||
| import { getUrlParams } from "./UrlParams.ts"; | ||
| import { MatrixRTCFocusMissingError } from "./utils/errors"; | ||
| import { getUrlParams } from "./UrlParams"; |
There was a problem hiding this comment.
The URL params should include a flag if it should ring or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this has been the responsibility of the hosting application (Element Web / Element X), but I would like to move this responsibility to Element Call itself to make it even more lightweight to integrate Element Call into a widget-capable client.
Depends on matrix-org/matrix-js-sdk#4826