Skip to content

stop listening timeline collection changes when app is not resumed #7734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

fedrunov
Copy link
Contributor

@fedrunov fedrunov commented Dec 7, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

currently we are listening to update in temeline events and request epoxy to build models even when app is on background. This triggers RR to be sent for this messages, while user actually haven't seen them yet.

In this PR adapter is removed on pause and set back on resume to not trigger visibility listener

Motivation and context

closes #7643

Screenshots / GIFs

Tests

  • Open any room
  • Put app on background
  • Receive push notification for message in this room
  • Notification should not be dismissed shortly after it was shown

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@fedrunov fedrunov requested review from a team, mnaturel and ganfra and removed request for a team December 7, 2022 10:14
@ElementBot
Copy link

Fails
🚫

node failed.

Log

Error:  Error: Could not find the Dangerfile at tools/danger/dangerfile-lint.js - does a file exist at dangerfile-lint.js in tools/danger?.
    at /usr/src/danger/distribution/platforms/GitHub.js:166:27
    at step (/usr/src/danger/distribution/platforms/GitHub.js:44:23)
    at Object.next (/usr/src/danger/distribution/platforms/GitHub.js:25:53)
    at fulfilled (/usr/src/danger/distribution/platforms/GitHub.js:16:58)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
danger-results://tmp/danger-results-cb4ec4ce.json

Generated by 🚫 dangerJS against 2308d4f

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@fedrunov fedrunov merged commit cf59c80 into develop Dec 9, 2022
@fedrunov fedrunov deleted the bugfix/nfe/notification_auto_dissmiss branch December 9, 2022 08:42
Kirchmaus pushed a commit to SchildiChat/SchildiChat-android that referenced this pull request Dec 16, 2022
…sumed (element-hq#7734)"

This makes the chat view get destroyed onPause, leading to
jump-to-bottom when clicking links, opening threads etc.

This reverts commit cf59c80.

Change-Id: I56ae7027d0488013251bc88edd0e47a19dead315
Kirchmaus pushed a commit to SchildiChat/SchildiChat-android that referenced this pull request Dec 16, 2022
…sumed (element-hq#7734)"

This makes the chat view get destroyed onPause, leading to
jump-to-bottom when clicking links, opening threads etc.

This reverts commit cf59c80.

Change-Id: I56ae7027d0488013251bc88edd0e47a19dead315
Kirchmaus pushed a commit to SchildiChat/SchildiChat-android that referenced this pull request Feb 23, 2023
…s not resumed (element-hq#7734)""

Upstream fix incoming

This reverts commit 987ca6d.

Change-Id: I3cec506b84cf1e469133df5276640d099e3c33de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications are (sometimes) automatically dismissed
4 participants