Use fatalError instead of NPE

[Johennes]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

As advised by @bmarty here this is switching from an NPE to fatalError to avoid crashing in production builds.

Tested devices

• Physical
• Emulator
• OS version(s): 12

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[Johennes]

I'm not sure if this needs a changelog entry but please tell me if it does.

[ouchadam]

maybe a controversial take, I would prefer to crash, giving the user feedback an unrecoverable error has occurred and the ability to submit logs the next time the app launches

perhaps a topic for the next team sync!

[bmarty]

Thanks!

[Johennes]

Thanks for fixing the unused import @bmarty! 🤦‍♂️

[github-actions]

Unit Test Results

  34 files   - 112    34 suites   - 112   32s ⏱️ - 2m 3s
  78 tests  - 158    78 ✔️  - 158  0 💤 ±0  0 ❌ ±0 
156 runs   - 632  156 ✔️  - 632  0 💤 ±0  0 ❌ ±0 

Results for commit df23fd1. ± Comparison against base commit 3cc1951.

This pull request removes 158 tests.

im.vector.app.core.extensions.StringExtensionsTest ‑ given text with RtL unicode override, when checking contains RtL Override, then returns true
im.vector.app.core.extensions.StringExtensionsTest ‑ given text with RtL unicode override, when ensuring ends LtR, then appends a LtR unicode override
im.vector.app.core.extensions.StringExtensionsTest ‑ given text with unicode direction overrides, when filtering direction overrides, then removes all overrides
im.vector.app.core.extensions.StringExtensionsTest ‑ given text without RtL unicode override, when checking contains RtL Override, then returns false
im.vector.app.features.analytics.impl.DefaultVectorAnalyticsTest ‑ given lateinit user properties when valid analytics id updates then identify with lateinit properties
im.vector.app.features.analytics.impl.DefaultVectorAnalyticsTest ‑ given user consent when tracking events then submits to posthog
im.vector.app.features.analytics.impl.DefaultVectorAnalyticsTest ‑ given user consent when tracking screen events then submits to posthog
im.vector.app.features.analytics.impl.DefaultVectorAnalyticsTest ‑ given user has not consented when tracking events then does not track
im.vector.app.features.analytics.impl.DefaultVectorAnalyticsTest ‑ given user has not consented when tracking screen events then does not track
im.vector.app.features.analytics.impl.DefaultVectorAnalyticsTest ‑ when consenting to analytics then updates posthog opt out to false
…

[bmarty]

CI is too long. Should be fine.

[github-actions]

Matrix SDK

Integration Tests Results:

• [org.matrix.android.sdk.session]
  = passed=20 failures=0 errors=0 skipped=3
• [org.matrix.android.sdk.account]
  = passed=3 failures=0 errors=0 skipped=2
• [org.matrix.android.sdk.internal]
  = passed=27 failures=1 errors=0 skipped=1
• [org.matrix.android.sdk.ordering]
  = passed=16 failures=0 errors=0 skipped=0
• [org.matrix.android.sdk.PermalinkParserTest]
  = passed=2 failures=0 errors=0 skipped=0