Skip to content

include dms number in space unread number badge #5434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2022
Merged

include dms number in space unread number badge #5434

merged 1 commit into from
Mar 9, 2022

Conversation

fedrunov
Copy link
Contributor

@fedrunov fedrunov commented Mar 7, 2022

fixes #5260

@github-actions
Copy link

github-actions bot commented Mar 7, 2022

Unit Test Results

  92 files  ±0    92 suites  ±0   1m 2s ⏱️ -18s
162 tests ±0  162 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
524 runs  ±0  524 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a3dcee5. ± Comparison against base commit bcdf004.

ouchadam
ouchadam approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@ouchadam ouchadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

would be handy to follow the PR template and provide context/screenshot 🙏

@bmarty bmarty merged commit 02ba099 into develop Mar 9, 2022
@bmarty bmarty deleted the feature/nfe/space_unread_count_dm branch March 9, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ouchadam ouchadam ouchadam approved these changes

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make notifications within a space truthful
3 participants
@fedrunov @ouchadam @bmarty