Skip to content

fix: correct colour for mobile menu active link #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented May 26, 2025

Since we apply .navbar--dark everywhere, we need to change the active link colour to match accordingly.

fix-mobile-menu-active-link electron-website pages dev_(iPhone 14 Pro Max)

Copy link

Deploying electron-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8185636
Status: ✅  Deploy successful!
Preview URL: https://88161fbd.electron-website.pages.dev
Branch Preview URL: https://fix-mobile-menu-active-link.electron-website.pages.dev

View logs

@erickzhao erickzhao marked this pull request as ready for review May 26, 2025 22:59
@erickzhao erickzhao requested a review from a team as a code owner May 26, 2025 22:59
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for posterity, this fixes the active link colors when the website is in light mode, the links are already correct in dark mode.

@dsanders11 dsanders11 merged commit 65ba775 into main May 27, 2025
7 checks passed
@dsanders11 dsanders11 deleted the fix/mobile-menu-active-link-color branch May 27, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants