fix: don't hold on to raw auth tokens #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
approved these changes
May 14, 2025
Comment on lines
+20
to
+22
| clientId: process.env.CLIENT_ID, | ||
| clientSecret: process.env.CLIENT_SECRET, | ||
| }, |
There was a problem hiding this comment.
I think previously we were just passing in the token here, will this method take the entire object and still work?
There was a problem hiding this comment.
Should! This is one of the forms shown in the docs: https://github.com/octokit/auth-app.js/?tab=readme-ov-file#usage-with-octokit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation is getting an installation auth token and then holding on to it indefinitely, which is a problem because those expire after 60 minutes. Refactor to use the proper approach to let Octokit fetch new tokens as needed.