fix: prevent UAF crash in setCertificateVerifyProc #33204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
deepak1556
previously approved these changes
Mar 9, 2022
patches/chromium/network_service_allow_remote_certificate_verification_logic.patch
Outdated
Show resolved
Hide resolved
deepak1556
dismissed
their stale review
Compilation errors needs to be addressed.
jkleinsc
previously requested changes
Mar 9, 2022
deepak1556
approved these changes
Mar 10, 2022
|
Release Notes Persisted
|
|
I was unable to backport this PR to "16-x-y" cleanly; |
|
I was unable to backport this PR to "15-x-y" cleanly; |
|
I was unable to backport this PR to "17-x-y" cleanly; |
|
I have automatically backported this PR to "18-x-y", please check out #33253 |
|
@nornagon do you have any idea when we could expect this fix to land in a 17+.x.y stable release? |
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
3 tasks
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This fixes a bug with the RemoteCertVerifier patch that drives the
ses.setCertificateVerifyProcAPI. When an in-flight request was cancelledafter the procedure was invoked but before the result was received, a
use-after-free could occur.
Fixes #31675.
Checklist
npm testpassesRelease Notes
Notes: Fixed a network service crash that could occur when using setCertificateVerifyProc.