feat: customNsisResources override in nsis options #9032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f95b1dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
indutny-signal
force-pushed
the
feature/custom-nsis-resources
branch
from
30e86c1 to
5d5792f
Compare
indutny-signal
changed the title
mmaietta
reviewed
Apr 16, 2025
indutny-signal
force-pushed
the
feature/custom-nsis-resources
branch
from
5d5792f to
75c8fd0
Compare
mmaietta
reviewed
Apr 16, 2025
Prior to this change `customNsisBinary` could be used to override the url of `nsis-*.7z` from the `electron-builder-binaries` repo to a custom location. However, there was no option to change the url of the `nsis-resources-*.7z` file. With this chcange the url of the NSIS resources could also be overriden.
indutny-signal
force-pushed
the
feature/custom-nsis-resources
branch
from
75c8fd0 to
f95b1dc
Compare
mmaietta
approved these changes
Apr 17, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change
customNsisBinarycould be used to override the url ofnsis-*.7zfrom theelectron-builder-binariesrepo to a custom location. However, there was no option to change the url of thensis-resources-*.7zfile.With this chcange the url of the NSIS resources could also be overriden.