Skip to content

[Inference] Fallback to kibana.dev.yml for connector config #226682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dgieselaar
Copy link
Member

@dgieselaar dgieselaar commented Jul 6, 2025

Currently, connectors for the Inference integration tests need to be defined as base64 encoded strings. This PR adds a fallback option for local development that will simply read the connectors from config/kibana.dev.yml which is good enough in most cases.

Notes:

@dgieselaar dgieselaar added the release_note:skip Skip the PR/issue when compiling release notes label Jul 6, 2025
@dgieselaar dgieselaar requested a review from a team as a code owner July 6, 2025 08:07
@dgieselaar dgieselaar added backport:version Backport to applied version labels v9.1.0 v8.19.0 v9.2.0 labels Jul 6, 2025
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/gen-ai-functional-testing 2 3 +1

Total ESLint disabled count

id before after diff
@kbn/gen-ai-functional-testing 2 3 +1

Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgieselaar dgieselaar merged commit 69ab34c into elastic:main Jul 7, 2025
23 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16112260274

@dgieselaar dgieselaar deleted the inference-tests-fallback-connector-config branch July 7, 2025 08:47
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 7, 2025
…226682)

Currently, connectors for the Inference integration tests need to be
defined as base64 encoded strings. This PR adds a fallback option for
local development that will simply read the connectors from
config/kibana.dev.yml which is good enough in most cases.

Notes:
- Bootstrapped simple implementation iterated on it, generated docs w/
Windsurf & o3:
https://windsurf.com/conversation-share/d393cf63-82cb-4d55-99ce-7f603e218160

(cherry picked from commit 69ab34c)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 7, 2025
…226682)

Currently, connectors for the Inference integration tests need to be
defined as base64 encoded strings. This PR adds a fallback option for
local development that will simply read the connectors from
config/kibana.dev.yml which is good enough in most cases.

Notes:
- Bootstrapped simple implementation iterated on it, generated docs w/
Windsurf & o3:
https://windsurf.com/conversation-share/d393cf63-82cb-4d55-99ce-7f603e218160

(cherry picked from commit 69ab34c)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.19
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 7, 2025
…26682) (#226734)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Inference] Fallback to kibana.dev.yml for connector config
(#226682)](#226682)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Dario
Gieselaar","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-07-07T08:46:23Z","message":"[Inference]
Fallback to kibana.dev.yml for connector config (#226682)\n\nCurrently,
connectors for the Inference integration tests need to be\ndefined as
base64 encoded strings. This PR adds a fallback option for\nlocal
development that will simply read the connectors
from\nconfig/kibana.dev.yml which is good enough in most
cases.\n\nNotes: \n- Bootstrapped simple implementation iterated on it,
generated docs w/\nWindsurf &
o3:\nhttps://windsurf.com/conversation-share/d393cf63-82cb-4d55-99ce-7f603e218160","sha":"69ab34c914fc9b5ed408ee87bee71f29bf37874d","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Inference]
Fallback to kibana.dev.yml for connector
config","number":226682,"url":"https://github.com/elastic/kibana/pull/226682","mergeCommit":{"message":"[Inference]
Fallback to kibana.dev.yml for connector config (#226682)\n\nCurrently,
connectors for the Inference integration tests need to be\ndefined as
base64 encoded strings. This PR adds a fallback option for\nlocal
development that will simply read the connectors
from\nconfig/kibana.dev.yml which is good enough in most
cases.\n\nNotes: \n- Bootstrapped simple implementation iterated on it,
generated docs w/\nWindsurf &
o3:\nhttps://windsurf.com/conversation-share/d393cf63-82cb-4d55-99ce-7f603e218160","sha":"69ab34c914fc9b5ed408ee87bee71f29bf37874d"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226682","number":226682,"mergeCommit":{"message":"[Inference]
Fallback to kibana.dev.yml for connector config (#226682)\n\nCurrently,
connectors for the Inference integration tests need to be\ndefined as
base64 encoded strings. This PR adds a fallback option for\nlocal
development that will simply read the connectors
from\nconfig/kibana.dev.yml which is good enough in most
cases.\n\nNotes: \n- Bootstrapped simple implementation iterated on it,
generated docs w/\nWindsurf &
o3:\nhttps://windsurf.com/conversation-share/d393cf63-82cb-4d55-99ce-7f603e218160","sha":"69ab34c914fc9b5ed408ee87bee71f29bf37874d"}}]}]
BACKPORT-->

Co-authored-by: Dario Gieselaar <[email protected]>
kibanamachine added a commit that referenced this pull request Jul 7, 2025
…226682) (#226733)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Inference] Fallback to kibana.dev.yml for connector config
(#226682)](#226682)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Dario
Gieselaar","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-07-07T08:46:23Z","message":"[Inference]
Fallback to kibana.dev.yml for connector config (#226682)\n\nCurrently,
connectors for the Inference integration tests need to be\ndefined as
base64 encoded strings. This PR adds a fallback option for\nlocal
development that will simply read the connectors
from\nconfig/kibana.dev.yml which is good enough in most
cases.\n\nNotes: \n- Bootstrapped simple implementation iterated on it,
generated docs w/\nWindsurf &
o3:\nhttps://windsurf.com/conversation-share/d393cf63-82cb-4d55-99ce-7f603e218160","sha":"69ab34c914fc9b5ed408ee87bee71f29bf37874d","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Inference]
Fallback to kibana.dev.yml for connector
config","number":226682,"url":"https://github.com/elastic/kibana/pull/226682","mergeCommit":{"message":"[Inference]
Fallback to kibana.dev.yml for connector config (#226682)\n\nCurrently,
connectors for the Inference integration tests need to be\ndefined as
base64 encoded strings. This PR adds a fallback option for\nlocal
development that will simply read the connectors
from\nconfig/kibana.dev.yml which is good enough in most
cases.\n\nNotes: \n- Bootstrapped simple implementation iterated on it,
generated docs w/\nWindsurf &
o3:\nhttps://windsurf.com/conversation-share/d393cf63-82cb-4d55-99ce-7f603e218160","sha":"69ab34c914fc9b5ed408ee87bee71f29bf37874d"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226682","number":226682,"mergeCommit":{"message":"[Inference]
Fallback to kibana.dev.yml for connector config (#226682)\n\nCurrently,
connectors for the Inference integration tests need to be\ndefined as
base64 encoded strings. This PR adds a fallback option for\nlocal
development that will simply read the connectors
from\nconfig/kibana.dev.yml which is good enough in most
cases.\n\nNotes: \n- Bootstrapped simple implementation iterated on it,
generated docs w/\nWindsurf &
o3:\nhttps://windsurf.com/conversation-share/d393cf63-82cb-4d55-99ce-7f603e218160","sha":"69ab34c914fc9b5ed408ee87bee71f29bf37874d"}}]}]
BACKPORT-->

Co-authored-by: Dario Gieselaar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v8.19.0 v9.1.0 v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants