Skip to content

[Search Home Page V1] Remove unused code following the release of the Search Home page #226664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

saikatsarkar056
Copy link
Contributor

@saikatsarkar056 saikatsarkar056 commented Jul 4, 2025

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@saikatsarkar056 saikatsarkar056 self-assigned this Jul 4, 2025
@saikatsarkar056 saikatsarkar056 added release_note:skip Skip the PR/issue when compiling release notes Team:Search backport:skip This commit does not require backporting labels Jul 4, 2025
@saikatsarkar056 saikatsarkar056 marked this pull request as ready for review July 7, 2025 04:33
@saikatsarkar056 saikatsarkar056 requested review from a team as code owners July 7, 2025 04:33
@saikatsarkar056 saikatsarkar056 marked this pull request as draft July 7, 2025 05:30
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 7, 2025

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!

@kibanamachine
Copy link
Contributor

Project deployments require a Github label, please add one or more of ci:project-deploy-(elasticsearch|observability|security) and trigger the job through the checkbox again.

@kibanamachine
Copy link
Contributor

Cloud deployments require a Github label, please add ci:cloud-deploy or ci:cloud-redeploy and trigger the job through the checkbox again.

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 7, 2025

💔 Build Failed

Failed CI Steps

History

cc @saikatsarkar056

@saikatsarkar056 saikatsarkar056 force-pushed the code_cleanup_for_search_homepage branch from b9bbe08 to 39bfdf9 Compare July 7, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants